Merge pull request dotnet#52647 from jcouv/merge-features-compiler

Merge features/compiler into features/record-structs

.editorconfig

@@ -260,6 +260,9 @@ dotnet_diagnostic.IDE0059.severity = warning
 # IDE0060: Remove unused parameter
 dotnet_diagnostic.IDE0060.severity = warning
 
+# CA1012: Abstract types should not have public constructors
+dotnet_diagnostic.CA1012.severity = warning
+
 # CA1822: Make member static
 dotnet_diagnostic.CA1822.severity = warning
 

CONTRIBUTING.md

@@ -4,7 +4,7 @@ Guidelines for contributing to the Roslyn repo.
 
 ## Submitting Pull Requests
 
-- **DO** ensure submissions pass all Jenkins legs and are merge conflict free.
+- **DO** ensure submissions pass all Azure DevOps legs and are merge conflict free.
 - **DO** follow the [.editorconfig](http://editorconfig.org/) settings for each directory. 
 - **DO** submit language feature requests as issues in the [C# language](https://github.com/dotnet/csharplang#discussion) / [VB language](https://github.com/dotnet/vblang) repos.  Once a feature is championed and validated by LDM, a developer will be assigned to help begin a prototype on this repo inside a feature branch.
 - **DO NOT** submit language features as PRs to this repo first, or they will likely be declined.

Compilers.sln

@@ -168,7 +168,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CodeStyleConfigFileGenerato
 EndProject
 Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.Collections", "src\Dependencies\Collections\Microsoft.CodeAnalysis.Collections.shproj", "{E919DD77-34F8-4F57-8058-4D3FF4C2B241}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Rebuild", "src\Compilers\Core\Rebuild\Rebuild.csproj", "{321F9FED-AACC-42CB-93E5-541D79E099E8}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild", "src\Compilers\Core\Rebuild\Microsoft.CodeAnalysis.Rebuild.csproj", "{321F9FED-AACC-42CB-93E5-541D79E099E8}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild.UnitTests", "src\Compilers\Core\RebuildTest\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj", "{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}"
 EndProject

Compilers.slnf

@@ -31,7 +31,7 @@
       "src\\Compilers\\Core\\MSBuildTask\\Microsoft.Build.Tasks.CodeAnalysis.csproj",
       "src\\Compilers\\Core\\Portable\\Microsoft.CodeAnalysis.csproj",
       "src\\Compilers\\Core\\RebuildTest\\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj",
-      "src\\Compilers\\Core\\Rebuild\\Rebuild.csproj",
+      "src\\Compilers\\Core\\Rebuild\\Microsoft.CodeAnalysis.Rebuild.csproj",
       "src\\Compilers\\Extension\\Roslyn.Compilers.Extension.csproj",
       "src\\Compilers\\Server\\VBCSCompilerTests\\VBCSCompiler.UnitTests.csproj",
       "src\\Compilers\\Server\\VBCSCompiler\\VBCSCompiler.csproj",

Roslyn.sln

@@ -483,7 +483,7 @@ Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.Coll
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Collections.Package", "src\Dependencies\Collections\Microsoft.CodeAnalysis.Collections.Package.csproj", "{0C2E1633-1462-4712-88F4-A0C945BAD3A8}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Rebuild", "src\Compilers\Core\Rebuild\Rebuild.csproj", "{B7D29559-4360-434A-B9B9-2C0612287999}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild", "src\Compilers\Core\Rebuild\Microsoft.CodeAnalysis.Rebuild.csproj", "{B7D29559-4360-434A-B9B9-2C0612287999}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild.UnitTests", "src\Compilers\Core\RebuildTest\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj", "{21B49277-E55A-45EF-8818-744BCD6CB732}"
 EndProject

azure-pipelines-official.yml

@@ -48,19 +48,19 @@ stages:
   - job: OfficialBuild
     displayName: Official Build
     timeoutInMinutes: 360
-    # Conditionally set build pool so we can share this YAML when building with different pipeline (devdiv vs dnceng) 
-    pool:      
+    # Conditionally set build pool so we can share this YAML when building with different pipeline (devdiv vs dnceng)
+    pool:
       ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
         name: VSEngSS-MicroBuild2017
-        demands: 
+        demands:
         - msbuild
         - visualstudio
         - DotNetFramework
       ${{ if eq(variables['System.TeamProject'], 'internal') }}:
         name: NetCoreInternal-Pool
         queue: BuildPool.Windows.10.Amd64.VS2019.Pre
 
-    steps:        
+    steps:
     # Make sure our two pipelines generate builds with distinct build numbers to avoid confliction.
     # i.e. DevDiv builds will have even rev# whereas dnceng builds will be odd.
     - task: PowerShell@2
@@ -82,7 +82,7 @@ stages:
         type: 'Build'
         tags: 'OfficialBuild'
       condition: and(succeeded(), endsWith(variables['SourceBranchName'], '-vs-deps'), eq(variables['PRNumber'], 'default'))
-          
+
     - task: tagBuildOrRelease@0
       displayName: Tag PR validation build
       inputs:
@@ -152,13 +152,13 @@ stages:
       displayName: Build
       inputs:
         filePath: eng/build.ps1
-        arguments: -ci 
+        arguments: -ci
                    -restore
                    -build
                    -pack
                    -sign
                    -publish
-                   -binaryLog 
+                   -binaryLog
                    -configuration $(BuildConfiguration)
                    -officialBuildId $(Build.BuildNumber)
                    -officialSkipTests $(SkipTests)
@@ -249,7 +249,7 @@ stages:
 
     # Publish insertion packages to CoreXT store.
     - task: NuGetCommand@2
-      displayName: Publish CoreXT Packages 
+      displayName: Publish CoreXT Packages
       inputs:
         command: push
         packagesToPush: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)\DevDivPackages\**\*.nupkg'
@@ -270,7 +270,7 @@ stages:
         ArtifactName: 'VSSetup'
       condition: succeeded()
 
-    # Publish our NuPkgs as an artifact. The name of this artifact must be PackageArtifacts as the 
+    # Publish our NuPkgs as an artifact. The name of this artifact must be PackageArtifacts as the
     # arcade templates depend on the name.
     - task: PublishBuildArtifacts@1
       displayName: Publish Artifact Packages
@@ -295,7 +295,7 @@ stages:
   - template: /eng/common/templates/job/publish-build-assets.yml
     parameters:
       publishUsingPipelines: true
-      dependsOn:	
+      dependsOn:
         - OfficialBuild
       ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
         queue:
@@ -304,7 +304,7 @@ stages:
         pool:
           vmImage: vs2017-win2016
 
-# We need to skip post-build stages for PR validation build, but it can only be identified by 
+# We need to skip post-build stages for PR validation build, but it can only be identified by
 # the runtime variable 'PRNumber', thus this dummy stage. Also the dummy job is required
 # otherwise AzDO would just repeat jobs from previous stage.
 - stage: SetValidateDependency
@@ -324,8 +324,8 @@ stages:
       # https://github.com/dotnet/arcade/issues/2871 is resolved.
       enableSymbolValidation: false
       enableSourceLinkValidation: false
-      # It's important that post-build stages are depends on 'SetValidateDependency' stage instead of 'build', 
-      # since we don't want to publish validation build. 
+      # It's important that post-build stages are depends on 'SetValidateDependency' stage instead of 'build',
+      # since we don't want to publish validation build.
       validateDependsOn:
         - SetValidateDependency
       dependsOn: