fix(api): deferred values are not truthy

jcrist · Jan 18, 2024 · 4533e4d · 4533e4d
1 parent 1d06b87
commit 4533e4d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/ibis/common/deferred.py b/ibis/common/deferred.py
@@ -97,6 +97,11 @@ def __getattr__(self, name):
     def __iter__(self):
         raise TypeError(f"{self.__class__.__name__!r} object is not iterable")
 
+    def __bool__(self):
+        raise TypeError(
+            f"The truth value of {self.__class__.__name__} objects is not defined"
+        )
+
     def __getitem__(self, name):
         return Deferred(Item(self, name))
 

diff --git a/ibis/common/tests/test_deferred.py b/ibis/common/tests/test_deferred.py
@@ -501,6 +501,14 @@ def test_deferred_is_not_iterable(obj):
         next(obj)
 
 
+@pytest.mark.parametrize("obj", [_, _.a, _.a.b[0]])
+def test_deferred_is_not_truthy(obj):
+    with pytest.raises(
+        TypeError, match="The truth value of Deferred objects is not defined"
+    ):
+        bool(obj)
+
+
 def test_deferrable(table):
     @deferrable
     def f(a, b, c=3):