fix(sqlite): ensure ibis.uuid() generates a unique uuid per row

jcrist · Mar 4, 2024 · 606a260 · 606a260
1 parent e8bc3b9
commit 606a260
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/ibis/backends/sqlite/udf.py b/ibis/backends/sqlite/udf.py
@@ -223,7 +223,7 @@ def pi():
     return math.pi
 
 
-@udf(skip_if_exists=True)
+@udf(skip_if_exists=True, deterministic=False)
 def uuid():
     return str(uuid4())
 
@@ -432,7 +432,8 @@ def __init__(self) -> None:
         self.value = None
 
     @abc.abstractmethod
-    def step(self, value): ...
+    def step(self, value):
+        ...
 
     def finalize(self) -> int | None:
         return self.value

diff --git a/ibis/backends/tests/test_uuid.py b/ibis/backends/tests/test_uuid.py
@@ -60,3 +60,26 @@ def test_uuid_function(con):
     obj = con.execute(ibis.uuid())
     assert isinstance(obj, uuid.UUID)
     assert obj.version == 4
+
+
+@pytest.mark.notimpl(
+    [
+        "datafusion",
+        "druid",
+        "exasol",
+        "flink",
+        "mssql",
+        "mysql",
+        "oracle",
+        "polars",
+        "pyspark",
+        "risingwave",
+    ],
+    raises=com.OperationNotDefinedError,
+)
+@pytest.mark.notimpl(["pandas", "dask"], raises=ValueError)
+def test_uuid_unique_each_row(con):
+    expr = (
+        con.tables.functional_alltypes.mutate(uuid=ibis.uuid()).limit(2).uuid.nunique()
+    )
+    assert expr.execute() == 2