Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try getattr first in convert(mapping, from_attributes=True) #519

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Try getattr first in convert(mapping, from_attributes=True) #519

merged 1 commit into from
Aug 16, 2023

Commits on Aug 16, 2023

  1. Try getattr first in convert(mapping, from_attributes=True) 

    Previously if a mapping was passed to `convert`, values would only be
extracted via `PyObject_GetItem` even if `from_attributes=True`. Some
object types define `__getitem__` but also store data via attribute. In
this case we want to try `PyObject_GetAttr` first, falling back to
`PyObject_GetItem`.
    @jcrist
    jcrist committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    69df460 View commit details
    Browse the repository at this point in the history