Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard copied code with clipr #21

Merged
merged 3 commits into from
Mar 18, 2023

Conversation

denisabd
Copy link

Hi Juan,

This is a PR to add clipboard functionality with clipr, which is a single new import.
Added your feedback, gsub() instead of str_replace_all() all in one line of code and function argument itself

Installed and tested all of the affected functions separately - everything works.

Thanks

Denis

@denisabd denisabd changed the title Clipr revised Clipboard copied code with clipr Mar 18, 2023
Copy link
Owner

@jcrodriguez1989 jcrodriguez1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were just missing this for complete_code. Will merge and then do minor changes.
This is perfect!!
@denisabd , thank you very much for your contribution!!

Comment on lines -26 to +27
utils
utils,
clipr
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put imports in alphabetical order. In this way, it is easier to avoid duplicate imports :)

@jcrodriguez1989 jcrodriguez1989 merged commit c366680 into jcrodriguez1989:develop Mar 18, 2023
@denisabd
Copy link
Author

Thanks a lot - I actually forked from main that is why I didn't have that other function you mentioned. Thanks for cleaning it up for me!

@denisabd denisabd deleted the clipr_revised branch March 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants