-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build size bot workflow #1
base: master
Are you sure you want to change the base?
Conversation
Size Change: -2 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
Hi This looks like a good start but you should figure out options to make this way less verbose. The js chunk hash is constantly changing (due to Webpack 4, webpack5 will be more deterministic afaik). Also, it's not useful to compare all HTML files with their previous versions, only a representative sample is enough (homepage, one doc, one blog post...) What probably matters most are some specific js bundles, the heavy ones (like |
Thank you for the tips @slorber |
bb8eb90
to
7349a1d
Compare
7349a1d
to
3d32594
Compare
Hi @slorber I've also picked 5 representative files for tracking the build size:
Please see the #1 (comment) above |
thanks @jcs98 that looks nice. enough to be merged can you open this pr to the main repo please? |
Thank you @slorber! |
Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)