Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greetings as function don't work #363

Closed
jcubic opened this issue Jan 2, 2018 · 1 comment
Closed

Greetings as function don't work #363

jcubic opened this issue Jan 2, 2018 · 1 comment

Comments

@jcubic
Copy link
Owner

jcubic commented Jan 2, 2018 •
edited
Loading

Expected behavior

If you use function as greetings it should display string returned by that function

Actual behavior

No Greetings

Steps to reproduce

Create default terminal with signature (it's not displayed).
jcubic added a commit that referenced this issue Jan 2, 2018
@jcubic
fix issue with not working greetings + update #363
c8f14cf 
the problem was that terminal width was 100 initialy and signature was empty and div for it was not created
and next time when it was updating it coun'd not found div with id for the greetings
@jcubic
Copy link
Owner Author

jcubic commented Jan 2, 2018

the problem was that terminal width was 100px initially and signature was empty and div for it was not created and next time when it was updating it could'd not found div with id for the greetings.

The fix will be in next version 1.11.3 or 1.12.0.

jcubic added a commit that referenced this issue Jan 7, 2018
@jcubic
better fix for echo function that return empty string #363
70109a9
@jcubic jcubic closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic