New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greetings function should allow to return a promise #531

Closed

jcubic opened this issue Oct 12, 2019 · 0 comments

Labels

feature resolved

Owner

jcubic commented Oct 12, 2019 •

edited

Loading

I have idea for a new feature for jQuery Terminal

There should be a way to have:

      greetings: function() {
          var token = this.get_token();
          // this will not work
          return fetch(`service.php?action=greetings&token=${token}`).then(r => r.text());
      }

found code review for rejected PR #529

jcubic changed the title ~~greetings function should all to return a promise~~ greetings function should allow to return a promise

jcubic added the feature label

jcubic added a commit that referenced this issue


          allow to return a promise from greetings function #531

14c8dfd

jcubic added the resolved label

jcubic closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment