-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_output don't handle promises #687
Comments
jcubic
added a commit
that referenced
this issue
Sep 8, 2021
jcubic
added a commit
that referenced
this issue
Sep 8, 2021
The code now works like this, if any of the lines resolve to a promise then get_output() will return a promise of a string. |
jcubic
added a commit
that referenced
this issue
Sep 8, 2021
Ther is still an issue, get_output() should not render the output, but get what is already printed on the terminal. |
jcubic
added a commit
that referenced
this issue
Sep 12, 2021
Introduce snapshot output in OutputLines class that contain lines that are printed on terminal. So they can be just returned to the user
jcubic
added
the
resolved
if issue is resolved, it will be open until merge with master
label
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue summary
If you echo promise and call get_output you get
[object Promise]
Expected behavior
I should get the value the promise is resolved to
Actual behavior
It return string
[object Promise]
Steps to reproduce
Found while writing unit tests for async echo, was not able to use
get_output()
in 1415082The text was updated successfully, but these errors were encountered: