Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill Interaction Causes Error in jquery.terminal - (Conflict libs ?) #977

Closed
KiddoV opened this issue Oct 8, 2024 · 3 comments
Closed
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@KiddoV
Copy link
Contributor

KiddoV commented Oct 8, 2024

Issue summary

When using the autofill feature in forms, I encounter an error in the jquery.terminal library.
Specifically, the error message is:

Uncaught TypeError: Cannot read properties of undefined (reading 'toLowerCase')

Expected behavior

No ERROR when using autofill in a form.

Steps to reproduce

  • Fill the form with AutoFill
  • Watch the error in console

https://jsfiddle.net/KiddoV/pdt2m5k0/17/

Browser and OS

Webview 2
Windows 10

Additional notes

jq-term-error

@KiddoV KiddoV added the Bug label Oct 8, 2024
@jcubic
Copy link
Owner

jcubic commented Oct 8, 2024

It looks like the keydown event is triggered without the key property that is supported by all major browsers.

@jcubic
Copy link
Owner

jcubic commented Oct 8, 2024

Should be fixed, the problem was that keydown even always intercepts all events even when terminal is disabled. So you can use CTRL+D to resume. And the autofill triggered fake keydown event.

You can test the devel branch, I will publish a fix when you confirm that everything is working.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Oct 8, 2024
@KiddoV
Copy link
Contributor Author

KiddoV commented Oct 8, 2024

@jcubic I have tested the devel branch and it is fixed!
Thanks for the quick patch as always! :)

jcubic added a commit that referenced this issue Oct 8, 2024
@jcubic jcubic closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

2 participants