Add clang tidy review in Lint CI (onnx#5041)

* add clang-tidy review Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * more configs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add post yml Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * rename Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * post Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * orkflow_dispatch Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Post clang-tidy review comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove workflow Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * test Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * revert demo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de>
jcwchen · Apr 4, 2023 · 5a7f21c · 5a7f21c
1 parent 878d59b
commit 5a7f21c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/.github/workflows/clang_tidy_review_post.yml b/.github/workflows/clang_tidy_review_post.yml
@@ -0,0 +1,15 @@
+# This standalone CI is needed for commenting in PRs
+name: Post clang-tidy review comments
+
+on:
+  workflow_run:
+    # The name field of the lint action
+    workflows: ["Lint"]
+    types:
+      - completed
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: ZedThree/clang-tidy-review/post@ddfe311e5d2ee5ea096cedc21adcbdb83c32f62b # v0.12.1
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -40,6 +40,17 @@ jobs:
           reporter: github-pr-check
           level: info
           filter_mode: diff_context
+      # Pleaes note that it won't cause any failure here; it will only post comments in PRs
+      - name: clang-tidy review
+        uses: ZedThree/clang-tidy-review@ddfe311e5d2ee5ea096cedc21adcbdb83c32f62b # v0.12.1
+        with:
+          build_dir: '.setuptools-cmake-build'
+          apt_packages: libprotobuf-dev protobuf-compiler
+          lgtm_comment_body: ''
+          exclude: "/third_party/*"
+          split_workflow: true
+      - uses: ZedThree/clang-tidy-review/upload@ddfe311e5d2ee5ea096cedc21adcbdb83c32f62b # v0.12.1
+
 
   enforce-style:
     name: Enforce style