Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color issue after fullscreen #132

Merged
merged 2 commits into from Nov 30, 2015
Merged

Fix background color issue after fullscreen #132

merged 2 commits into from Nov 30, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2015

Currently the background color is not working after entering fullscreen.
This code snip should fix the issue.
I only tested it for my Chrome(46.0.2490.86).

Currently the background color is not working after entering fullscreen.
This code snip should fix the issue.
I only tested it for my Chrome(46.0.2490.86).
@jdan
Copy link
Owner

jdan commented Nov 30, 2015

Hey @yielder,

Thanks for this - can you post a screenshot of the background color not filling the entire area? I'm on Chrome 46 on OSX and the color seems to take up the whole screen without issue.

@ghost
Copy link
Author

ghost commented Nov 30, 2015

To make contrast clear I changed original to red:
before enter fullscreen:
screen shot 2015-11-30 at 02 24 04
after fullscreen:
screen shot 2015-11-30 at 02 24 46
My Chrome is also on OSX btw.
Also, I need to manually add code snip like the one I requested for almost all other cleaver themes in the style.css file to make it behave normally in fullscreen mode..

@jdan
Copy link
Owner

jdan commented Nov 30, 2015

Ah, thank you!

If that's the case, maybe we should instead move the background-color from body { } to .slide { } in default.css?

Thank you very much for pointing this out, and yeah I definitely missed it without changing the color to red first.

@ghost
Copy link
Author

ghost commented Nov 30, 2015

Moving the background-color from body { } to .slide { } in default.css also works.
It seems simpler~

jdan added a commit that referenced this pull request Nov 30, 2015
Fix background color issue after fullscreen
@jdan jdan merged commit ba7736a into jdan:master Nov 30, 2015
@jdan
Copy link
Owner

jdan commented Nov 30, 2015

Woohoo - thanks again 🌟 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant