hotfix: noop callbacks for the createAndSave function solves #171 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudodoki
reviewed
Jun 14, 2017
bin/cleaver
Outdated
| @@ -69,7 +69,9 @@ program | |||
| var file = program.args[0]; | |||
| var options = getOptions(); | |||
| options.watch = true; | |||
| createAndSave([file], options); | |||
| createAndSave([file], options, function() { | |||
|
|
|||
There was a problem hiding this comment.
can you have it the same way, on single line, like in the other one, please?
|
Thanks so much for stepping up and providing fix for this! 👏 Can you do this little change from comment as well, please? |
|
There! |
|
Looks good. Will try to merge & publish over weekend or maybe someone else will get to that before me. 😉 |
|
Fixes #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dirty but solves the issue.