Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tabindex #32

Closed

Conversation

redtrumpet
Copy link
Contributor

No description provided.

@jdan
Copy link
Owner

jdan commented Sep 2, 2013

Not seeing any difference in behavior here, what's the expected result? FF 17 and Chrome 29 on Mac OS X 10.8

@redtrumpet
Copy link
Contributor Author

If you have got a presentation, which contains the url or the twitter of the user and press TAB, the wrapper automatically scrolls to the link, because it's selected. In Chrome, it exactly scrolls to the containing slide, but in FF it doesn't:
screen-cleaver

And tabindex="-1" prevents the links from being selected, so the wrapper does not scroll to them.

All tested on Windows.

@jdan
Copy link
Owner

jdan commented Sep 2, 2013

Awesome, thanks. Fix landed in 8576f46.

@jdan jdan closed this Sep 2, 2013
@redtrumpet redtrumpet deleted the 31-add-tabindex-to-author-links branch September 2, 2013 16:30
@jdan
Copy link
Owner

jdan commented Nov 4, 2013

Thanks for first pointing this out to me, I think I've fixed the issue for good under 83df782.

There was an issue with slides skipping to a weird transition state when tabbing to a URL. I guess before we only caught this with URLs on the author slide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants