Renamed emboss to extrude, arrays tested with Array.isArray #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed testing if an object is an array from checking toString type to using Array.isArray
| @@ -6,7 +6,7 @@ | |||
| (function (exports) { | |||
|
|
|||
| function Path(points) { | |||
| if (Object.prototype.toString.call(points) === '[object Array]') { | |||
| if (Array.prototype.isArray.call(points)) { | |||
There was a problem hiding this comment.
You really only need Array.isArray(points) here, but this is somewhat non-canonical (IE > 8).
Object.prototype.toString is super airtight.
|
Landed in bcb83c7. Thanks 🌟 |
|
Cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most graphical applications, such as Maya and 3D Studio Max use the term "extrude" instead of "emboss".
Instead of using toString to test if an object type is an array, use the Array class's isArray function to perform the test.