Expose the light position so that it can be modified #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves issue #2 except the color portion. I forgot I mentioned that and didn't actually write code for it. I'm getting sloppy... |
jdan
added a commit
that referenced
this pull request
Apr 27, 2014
Expose the light position so that it can be modified
|
I was originally opposed to having a setter for this, but it's a good idea since we only want the user the specify a light position (not an angle), and we don't want to calculate the angle every time we draw a surface. Thanks for this, cool stuff. |
|
No problem. Yea, exposing calculated values isn't exactly the best idea and is where setters are useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.