Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for showing the tag names in color #31

Closed
wants to merge 1 commit into from

Conversation

jlopezr
Copy link

@jlopezr jlopezr commented Aug 8, 2017

No description provided.

Copy link
Contributor

@jamescat jamescat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this feature! -- However, I wonder about its compatibility with various terminal types, and particularly output to scripts / pipes / files / etc.

I didn't see anything that's obviously checking for whether the output of the command is to a file or tty, or anything which would make the color output "smart" like it should be about not sending control characters into non-tty devices.

Also, just a nitpicky tidiness issue I noticed... it looks like most values are immediately following the preceding colons, but in L773, L791, L818, & L957 at least, your additions include a space after the colon. Simply for code consistency, it might be best to remove those.

@jdberry
Copy link
Owner

jdberry commented Jun 28, 2019

Thanks @jlopezr. I modified and merged this in 7aad1ed.

@jdberry jdberry closed this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants