Remove antlr4-runtime dependency #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline the dependency into the core jar. This removes the long standing problem that jdbi creates version conflicts when used in projects that also use antlr4 and that use a different runtime version. Unfortunately antlr insists on a strong relationship between the generated classes for the grammar and the runtime. Inlining this dependency makes allows JDBI users to choose their antlr version arbitrarily as JDBI will use its private version.
|
Fixes #1798 |
stevenschlansker
approved these changes
Feb 24, 2022
electrum
reviewed
Feb 28, 2022
| @@ -792,6 +793,16 @@ | |||
| </pomElements> | |||
| </configuration> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>org.basepom.maven</groupId> | |||
| <artifactId>inline-maven-plugin</artifactId> | |||
There was a problem hiding this comment.
Cool! Looks like the repository is not available? https://github.com/basepom/inline-maven-plugin
There was a problem hiding this comment.
oops. It is public now. I kept it private for a while because the code changed a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline the dependency into the core jar. This removes the long
standing problem that jdbi creates version conflicts when used in
projects that also use antlr4 and that use a different runtime
version. Unfortunately antlr insists on a strong relationship between
the generated classes for the grammar and the runtime.
Inlining this dependency makes allows JDBI users to choose their antlr
version arbitrarily as JDBI will use its private version.