Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin to remove rtl #2673
feat: add plugin to remove rtl #2673
Changes from 2 commits
df471b9
f2034e9
39ca790
9b6f506
5b560c5
98ff201
d012b64
ebcf2b3
5e41224
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
检查代码中 'dongdesign' 的引用是否正确
在第 25 行和第 26 行中,代码检查了
sourceFile
是否不包含'@dongdesign'
。请确认这里的'@dongdesign'
是否应替换为'@nutui'
,以确保包名的一致性,避免混淆。建议修改如下:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
为函数参数添加类型注解
在异步函数
replaceCssVariables
中,参数root
未指定类型。建议为其添加类型注解,例如postcss.Root
,以增强类型检查和代码可读性。修改如下:
📝 Committable suggestion