-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build site failed in V3.0 #2682
Conversation
Walkthrough此次更改主要集中在 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## V3.0 #2682 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 221 221
Lines 17849 17849
Branches 2679 2679
=======================================
Hits 14986 14986
Misses 2858 2858
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
vite.config.site.ts (2)
45-45
: 示例路径中存在拼写错误
dclearesign
看起来是design
的拼写错误。建议修正为:
-// example : additionalData: `@import "./src/dclearesign/styles/variables";` +// example : additionalData: `@import "./src/design/styles/variables";`
47-50
: SCSS 配置更新解决了构建问题
- 使用
modern-compiler
API 是一个良好的改进- 通过
silenceDeprecations
抑制特定的弃用警告是解决构建失败的有效方案但建议添加注释说明为什么需要抑制这些特定的警告,以便未来维护。
建议添加说明性注释:
silenceDeprecations: ['import', 'global-builtin'], +// 抑制 Sass 模块导入和全局内置函数的弃用警告,以解决 V3.0 构建失败问题
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
vite.config.site.ts
(2 hunks)
🔇 Additional comments (1)
vite.config.site.ts (1)
24-29
: 区域设置路径更新符合标准命名规范
路径从 enUS
更新为 en-US
的修改是正确的,这符合国际化路径的标准命名规范。
Summary by CodeRabbit
新功能
样式
next
分支运行。