Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): 修复 plain 与 type 同时使用时的样式错误 #606

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Jan 31, 2023

🤔 这个变动的性质是?

  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式/交互改进
  • 测试用例
  • 其他改动

💡 需求背景和解决方案

存在问题:
同时使用 type、color、plain 时,生成样式的逻辑错误。

本次提交包含以下内容:
1、修改样式生成逻辑,与 NutUI-Vue 保持一致
2、移除多余的样式变量及其文档说明
3、更新了单元测试
4、优化了 Tag 类名生成逻辑

效果图:
image

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fock仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

@oasis-cloud oasis-cloud merged commit ef7c993 into jdf2e:main Jan 31, 2023
@eiinu eiinu deleted the fix-tag branch February 27, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants