Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ellipsis 展开和关闭操作应该阻止事件冒泡 #700

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

oasis-cloud
Copy link
Collaborator

🤔 这个变动的性质是?

  • 日常 bug 修复

🔗 相关 Issue

#692

💡 需求背景和解决方案

ellipsis 组件的 onClick 加在最外层的 HTML 标签上,展开和关闭的 HTML 在内层,并且带有 onClick 事件,不过并没有加阻止冒泡的处理,导致展开和关闭点击的时候会触发父元素的 onClick

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档无须补充
  • 代码演示已提供或无须提供

@oasis-cloud oasis-cloud added this to the v1.4.8 milestone Feb 20, 2023
@xiaoyatong xiaoyatong merged commit b823750 into main Feb 21, 2023
@oasis-cloud oasis-cloud deleted the fix/ellipsis-stopPropagation branch February 28, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ellipsis组件点击展开、收起会触发onClick事件,是否合理?
2 participants