Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled semantic highlighting #80

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

kronodeus
Copy link
Contributor

Enabled semantic highlighting on all themes. See the VS Code Semantic Highlighting Guide for more information.

In the examples below you will see the difference in how functions are highlighted. This is closer to how the modern built-in VS Code themes work.

Before

Screenshot 2023-08-23 at 11 50 46 AM

After

Screenshot 2023-08-23 at 11 51 27 AM

@jdinhify
Copy link
Owner

Thanks @kronodeus , let's enable this

@jdinhify jdinhify merged commit dc3310d into jdinhify:main Oct 24, 2023
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
# [1.9.0](v1.8.0...v1.9.0) (2023-10-24)

### Features

* enable semantic highlighting ([#80](#80)) ([dc3310d](dc3310d))
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
# [1.9.0](v1.8.0...v1.9.0) (2023-10-24)

### Features

* enable semantic highlighting ([#80](#80)) ([dc3310d](dc3310d))
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
# [1.9.0](v1.8.0...v1.9.0) (2023-10-24)

### Features

* enable semantic highlighting ([#80](#80)) ([dc3310d](dc3310d))
@funkindy
Copy link

Something broke with python highlighting after this:
before:
image

after:
image

@kronodeus
Copy link
Contributor Author

@funkindy Forgive me if I'm mistaken, because I do not know Python very well, but it looks like it was broken before? Notice async is highlighted in two different colors, and sa_session and session are highlighted differently despite both being functions.

@funkindy
Copy link

@kronodeus sorry, its better to say it became "worse" (subjectively), not broken. Anyway, here is a tip to overcome this #82

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants