4474/refactor/covers remove inline js (internetarchive#4596)

Inline JavaScript inside covers/manage.html is moved to index.js
jdlrobson · Feb 14, 2021 · 55a6a39 · 55a6a39
1 parent 3d15c02
commit 55a6a39
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/openlibrary/plugins/openlibrary/js/index.js b/openlibrary/plugins/openlibrary/js/index.js
@@ -161,4 +161,15 @@ jQuery(function () {
     });
 
     $('#wikiselect').on('focus', function(){$(this).select();})
+
+    // Functionality for manage.html
+    $('.column').sortable({
+        connectWith: '.trash'
+    });
+    $('.trash').sortable({
+        connectWith: '.column'
+    });
+    $('.column').disableSelection();
+    $('.trash').disableSelection();
+    $('#topNotice').hide();
 });
diff --git a/openlibrary/templates/covers/manage.html b/openlibrary/templates/covers/manage.html
@@ -3,20 +3,6 @@
 $putctx("bodyid", "form")
 $putctx('robots', 'noindex,nofollow')
 
-<script type="text/javascript">
-window.q.push(function () {
-    \$(".column").sortable({
-        connectWith: '.trash'
-    });
-    \$(".trash").sortable({
-        connectWith: '.column'
-    });
-    \$(".column").disableSelection();
-    \$(".trash").disableSelection();
-    \$("#topNotice").hide();
-});
-</script>
-
 <div class="imageIntro">
     $_("You can drag and drop thumbnails to reorder, or into the trash to delete them.")
 </div>