Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial (new/connect/practice) window doesnt get redrawn after being idled #81

Closed
kotc opened this issue Dec 22, 2020 · 6 comments
Closed
Assignees
Labels
bug pending-release Fix is tested and will be part of the next JSettlers release.

Comments

@kotc
Copy link
Contributor

kotc commented Dec 22, 2020

happens after some time when i finish the game, yet i forget to close the main window. the window is functional and is the one from second screenshot

@kotc
Copy link
Contributor Author

kotc commented Dec 22, 2020

@kotc
Copy link
Contributor Author

kotc commented Dec 22, 2020

and it's a 'start a server' window, not the (new/connect/practice), eh

@jdmonin
Copy link
Owner

jdmonin commented Dec 27, 2020

Thanks, I'll take a look. That window sure does look confused

@jdmonin jdmonin self-assigned this Dec 27, 2020
@jdmonin
Copy link
Owner

jdmonin commented Dec 27, 2020

If I understand, did you start a server running on your machine, played a game on that server, then left it alone for maybe a couple of hours?

@kotc
Copy link
Contributor Author

kotc commented Dec 27, 2020

exactly, so:
1/ start local server
2/ play game
3/ after finishing the game, close the game window, but dont touch the server/game creation window

after some time (never really measured this, but it's relatively long something times out, so it moves from the screen where you create game to the 'start server' window, but without correctly updating contents. it looks like fields/buttons are there, just java doesnt do a window refresh

@jdmonin jdmonin added the bug label Dec 27, 2020
jdmonin added a commit that referenced this issue Feb 15, 2021
…ractice panel with error text and only its initial 3 main buttons, all enabled; SOCConnectOrPracticePanel +lostServerConnection; genericServer.NetConnection TIMEOUT_VALUE clarify calc, javadoc; for github issue #81
jdmonin added a commit that referenced this issue Feb 16, 2021
…stead of timing out after an hour; ClientNetwork +PING_LOCAL_SERVER_INTERVAL_MS; SOCServerPing +javadocs, SOCMessageFromUnauthClient marker; for issue #81
@jdmonin jdmonin added the pending-release Fix is tested and will be part of the next JSettlers release. label Sep 21, 2021
@jdmonin
Copy link
Owner

jdmonin commented Dec 31, 2021

This fix was released as part of v2.5.00. Thanks again!

@jdmonin jdmonin closed this as completed Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pending-release Fix is tested and will be part of the next JSettlers release.
Projects
None yet
Development

No branches or pull requests

2 participants