feat: allow inserting PATH in env._.source

Fixes #3646

e2e/env/test_env_source

@@ -7,6 +7,8 @@ EOF
 
 cat >"$MISE_CONFIG_DIR/source.sh" <<EOF
 export MISE_TEST_SOURCE=1234
+export PATH="$HOME/newbin:$PATH"
 EOF
 
 assert "mise env -s bash | grep MISE_TEST_SOURCE" "export MISE_TEST_SOURCE=1234"
+assert_contains "mise env -s bash | grep PATH" "export PATH='$HOME/newbin:"

mise.lock

@@ -44,7 +44,7 @@ version = "0.2.3"
 backend = "cargo:toml-cli"
 
 [tools."cargo:usage-cli"]
-version = "1.7.1"
+version = "1.6.0"
 backend = "cargo:usage-cli"
 
 [tools.cosign]

src/backend/asdf.rs

@@ -143,7 +143,7 @@ impl AsdfBackend {
         }
         let script = sm.get_script_path(&ExecEnv);
         let dir = dirs::CWD.clone().unwrap_or_default();
-        let ed = EnvDiff::from_bash_script(&script, &dir, &sm.env)?;
+        let ed = EnvDiff::from_bash_script(&script, &dir, &sm.env, Default::default())?;
         let env = ed
             .to_patches()
             .into_iter()

src/config/env_directive/mod.rs

@@ -224,6 +224,7 @@ impl EnvResults {
                         &mut ctx,
                         &mut tera,
                         &mut env,
+                        &mut paths,
                         &mut r,
                         normalize_path,
                         &source,

src/config/env_directive/source.rs

@@ -1,14 +1,16 @@
 use crate::config::env_directive::EnvResults;
-use crate::env_diff::{EnvDiff, EnvDiffOperation, EnvMap};
+use crate::env_diff::{EnvDiff, EnvDiffOperation, EnvDiffOptions, EnvMap};
 use indexmap::IndexMap;
 use std::path::{Path, PathBuf};
+use crate::env;
 
 impl EnvResults {
     #[allow(clippy::too_many_arguments)]
     pub fn source(
         ctx: &mut tera::Context,
         tera: &mut tera::Tera,
         env: &mut IndexMap<String, (String, Option<PathBuf>)>,
+        paths: &mut Vec<(PathBuf, PathBuf)>,
         r: &mut EnvResults,
         normalize_path: fn(&Path, PathBuf) -> PathBuf,
         source: &Path,
@@ -19,13 +21,25 @@ impl EnvResults {
         if let Ok(s) = r.parse_template(ctx, tera, source, &input) {
             for p in xx::file::glob(normalize_path(config_root, s.into())).unwrap_or_default() {
                 r.env_scripts.push(p.clone());
-                let env_diff = EnvDiff::from_bash_script(&p, config_root, env_vars.clone())
+                let orig_path = env_vars.get(&*env::PATH_KEY).cloned().unwrap_or_default();
+                let mut env_diff_opts = EnvDiffOptions::default();
+                env_diff_opts.ignore_keys.shift_remove(&*env::PATH_KEY); // allow modifying PATH
+                let env_diff = EnvDiff::from_bash_script(&p, config_root, env_vars.clone(), env_diff_opts)
                     .unwrap_or_default();
                 for p in env_diff.to_patches() {
                     match p {
                         EnvDiffOperation::Add(k, v) | EnvDiffOperation::Change(k, v) => {
-                            r.env_remove.remove(&k);
-                            env.insert(k.clone(), (v.clone(), Some(source.to_path_buf())));
+                            if k == *env::PATH_KEY {
+                                // TODO: perhaps deal with path removals as well
+                                if let Some(new_path) = v.strip_suffix(&orig_path) {
+                                    for p in env::split_paths(new_path) {
+                                        paths.push((p, source.to_path_buf()));
+                                    }
+                                }
+                            } else {
+                                r.env_remove.remove(&k);
+                                env.insert(k.clone(), (v.clone(), Some(source.to_path_buf())));
+                            }
                         }
                         EnvDiffOperation::Remove(k) => {
                             env.shift_remove(&k);