fix: do not auto-install on mise x if some tools are passed

jdx · Nov 29, 2024 · 35d31a1 · 35d31a1
1 parent 4c12502
commit 35d31a1
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 4 deletions.
diff --git a/.github/workflows/autofix.yml b/.github/workflows/autofix.yml
@@ -41,6 +41,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - run: mise x -- bun i
       - run: mise run render

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -33,6 +33,7 @@ jobs:
         with:
           install_args: bun
           cache: true
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: bun i
       - run: mise run docs:release
         env:

diff --git a/.github/workflows/hyperfine.yml b/.github/workflows/hyperfine.yml
@@ -57,6 +57,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - run: |
           CMDS=(

diff --git a/.github/workflows/release-plz.yml b/.github/workflows/release-plz.yml
@@ -50,6 +50,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - run: mise x -- bun i
       - run: mise run release-plz

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -156,6 +156,7 @@ jobs:
       - run: tar -C "$HOME" -xvJf "dist/mise-$(./scripts/get-version.sh)-linux-x64.tar.xz"
       - run: echo "$HOME/mise/bin" >> "$GITHUB_PATH"
       - run: mise -v
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise i
       - name: Run e2e tests
         uses: nick-fields/retry@v3

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -53,8 +53,8 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise i
-      - run: mise x -- wait-for-gh-rate-limit
 
   build-macos:
     runs-on: macos-latest
@@ -108,8 +108,8 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise i
-      - run: mise x -- wait-for-gh-rate-limit
 
   unit:
     strategy:
@@ -147,6 +147,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - run: mise x -- bun i
       - run: mise x -- cargo test --all-features
@@ -178,6 +179,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - run: mise run test:shuffle
 
@@ -220,7 +222,7 @@ jobs:
             ~/.local/share/mise
             ~/.cache/mise
       - run: echo "$PWD/target/debug" >> "$GITHUB_PATH" && chmod +x target/debug/mise
-      - run: mise x -- wait-for-gh-rate-limit
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - name: Test w/ coverage
         uses: nick-fields/retry@v3
         env:
@@ -271,6 +273,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - name: e2e
         uses: nick-fields/retry@v3
@@ -315,6 +318,7 @@ jobs:
           path: |
             ~/.local/share/mise
             ~/.cache/mise
+      - run: mise x wait-for-gh-rate-limit -- wait-for-gh-rate-limit
       - run: mise install
       - uses: nick-fields/retry@v3
         with:

diff --git a/src/cli/exec.rs b/src/cli/exec.rs
@@ -64,7 +64,11 @@ impl Exec {
             jobs: self.jobs,
             raw: self.raw,
             // prevent installing things in shims by checking for tty
-            missing_args_only: !SETTINGS.exec_auto_install || !console::user_attended_stderr(),
+            // also don't autoinstall if at least 1 tool is specified
+            // in that case the user probably just wants that one tool
+            missing_args_only: !self.tool.is_empty()
+                || !SETTINGS.exec_auto_install
+                || !console::user_attended_stderr(),
             resolve_options: Default::default(),
         };
         measure!("install_arg_versions", {