fix: do not set debug mode when calling mise -v

jdx · Dec 9, 2024 · 371f95b · 371f95b
1 parent d6c2cd9
commit 371f95b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/cli/mod.rs b/src/cli/mod.rs
@@ -75,7 +75,7 @@ pub enum LevelFilter {
 }
 
 #[derive(clap::Parser, Debug)]
-#[clap(name = "mise", version = &*version::VERSION, about, long_about = LONG_ABOUT, after_long_help = AFTER_LONG_HELP, author = "Jeff Dickey <@jdx>", arg_required_else_help = true)]
+#[clap(name = "mise", about, long_about = LONG_ABOUT, after_long_help = AFTER_LONG_HELP, author = "Jeff Dickey <@jdx>", arg_required_else_help = true)]
 pub struct Cli {
     #[clap(subcommand)]
     pub command: Option<Commands>,
@@ -142,6 +142,8 @@ pub struct Cli {
     /// Show extra output (use -vv for even more)
     #[clap(short='v', long, global=true, overrides_with="quiet", action=ArgAction::Count)]
     pub verbose: u8,
+    #[clap(long, short='V', hide=true)]
+    pub version: bool,
     /// Answer yes to all confirmation prompts
     #[clap(short = 'y', long, global = true)]
     pub yes: bool,

diff --git a/src/cli/version.rs b/src/cli/version.rs
@@ -71,7 +71,7 @@ pub fn print_version_if_requested(args: &[String]) -> std::io::Result<bool> {
     let mise_bin = "mise.exe";
     if args.len() == 2 && *env::MISE_BIN_NAME == mise_bin {
         let cmd = &args[1].to_lowercase();
-        if cmd == "version" || cmd == "-v" || cmd == "--version" {
+        if cmd == "version" || cmd == "-v" || cmd == "--version" || cmd == "v" {
             show_version()?;
             return Ok(true);
         }

diff --git a/src/config/settings.rs b/src/config/settings.rs
@@ -7,6 +7,7 @@ use confique::env::parse::{list_by_colon, list_by_comma};
 use confique::{Config, Partial};
 use eyre::{bail, Result};
 use indexmap::{indexmap, IndexMap};
+use itertools::Itertools;
 use once_cell::sync::Lazy;
 use serde::ser::Error;
 use serde_derive::{Deserialize, Serialize};
@@ -142,7 +143,9 @@ impl Settings {
                 settings.trace = true;
             }
         }
-        if settings.verbose {
+        let args = env::args().collect_vec();
+        // handle the special case of `mise -v` which should show version, not set verbose
+        if settings.verbose && !(args.len() == 2 && args[1] == "-v") {
             settings.quiet = false;
             if settings.log_level != "trace" {
                 settings.log_level = "debug".to_string();