Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mise.run should install musl variant whenever this is available #2276

Closed
autarch opened this issue Jun 10, 2024 · 4 comments · Fixed by #3261
Closed

mise.run should install musl variant whenever this is available #2276

autarch opened this issue Jun 10, 2024 · 4 comments · Fixed by #3261

Comments

@autarch
Copy link
Contributor

autarch commented Jun 10, 2024

Right now it looks like it will pick the musl variant if the system uses it, but it doesn't check whether the installed libc is recent enough. This leads to situations where you can install mise but it won't run because libc is too old.

I think the best solution to this is just to always use the musl version by default.

@jdx
Copy link
Owner

jdx commented Nov 28, 2024

musl variant of what? I don't know of any logic that prefers one to the other

@autarch
Copy link
Contributor Author

autarch commented Nov 28, 2024

Wow, what a terribly bug report. Who wrote this? Oh, I did 😢

I think I was saying that the script https://mise.run/ should prefer the musl variant on Linux systems. Otherwise, it can end up installing a mise binary that requires a newer glibc than is available on a given system. Preferring the musl variant eliminates this issue.

@autarch
Copy link
Contributor Author

autarch commented Nov 28, 2024

Or in other words, instead of only choosing the musl variant if /bin/ls links to musl, get rid of that conditional and always use the musl variant.

@jdx
Copy link
Owner

jdx commented Nov 28, 2024

Oh no you put that in the title but I suppose I missed that when I replied. Somehow I was thinking about tool installs

jdx added a commit that referenced this issue Nov 28, 2024
Fixes #2276

@autarch says this is a good idea, I suppose we will see
jdx added a commit that referenced this issue Nov 28, 2024
Fixes #2276

@autarch says this is a good idea, I suppose we will see
@jdx jdx closed this as completed in #3261 Nov 28, 2024
@jdx jdx closed this as completed in 3860e95 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants