-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added "en" command #1697
feat: added "en" command #1697
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
I think I figured out a decent way forward. I just put some docs on how to disable the rc files with bash or zsh. I think that's better than trying to automatically do anything. |
48cb851
to
adebad7
Compare
docs/cli-reference.md
Outdated
## `mise en [OPTIONS] [DIR]` | ||
|
||
```text | ||
[experimental] starts a new shell with the mise environment built from the current configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think $SHELL
should be the default command launched
For the extra configuration like --shell SHELL
... should this just support any command and be more like mise x -- <etc>
but with a working directory set?
(The description of --cd
uses "command" instead of "shell")
Asking because even with a shell, someone may want to be able to pass additional arguments like -r
for restricted shell, or -l
for login session, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this just support any command and be more like mise x -- but with a working directory set?
well this is a very good point. I am going to need to ponder on this one a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$SHELL
is the default, but it has edge cases
fad123b
to
d13511e
Compare
3769c93
to
206f514
Compare
I think my issue is actually limited to fish (what I use) and how Well, it would be an issue if it was in ~/.zshenv or whatever the bash equivalent to that is but I think in that case I can just tell users not to do that since that shouldn't be there anyways. Anyhow, this might be just a fish thing mostly but I fixed fish. |
0085704
to
59bcdad
Compare
Fixes #1655
@booniepepper this isn't working right but I'm curious if you have any ideas.
The problem is that it will still load your rc files, so if you do something like `export PATH="/opt/homebrew/bin:$PATH" in your rc file that will make the mise tools lower priority than homebrew so it won't use mise tools if brew provides any.
One idea I had was running
mise env
when the shell starts but I'm not sure if it's possible to have zsh (for example) load a script like that.Technically it does work though.