-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explorations into task dir issues #1873
Draft
jatinn
wants to merge
2,029
commits into
jdx:main
Choose a base branch
from
jatinn:task-dir-exploration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* use serde to parse tools * Commit from GitHub Actions (test) * use serde to parse tools --------- Co-authored-by: mise[bot] <123107610+mise-en-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#1611) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
on my current hotel internet http does not work
* feat(task): extend mise tasks output * fix: update snapshot * fix: use -x,--extended instead of --full
* chore: release 2024.3.11 * Commit from GitHub Actions (test)
Bumps [h2](https://github.com/hyperium/h2) from 0.3.25 to 0.3.26. - [Release notes](https://github.com/hyperium/h2/releases) - [Changelog](https://github.com/hyperium/h2/blob/v0.3.26/CHANGELOG.md) - [Commits](hyperium/h2@v0.3.25...v0.3.26) --- updated-dependencies: - dependency-name: h2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jdx
force-pushed
the
main
branch
2 times, most recently
from
April 23, 2024 19:21
fad123b
to
d13511e
Compare
@jdx are any of these approaches to the fix worth cleaning up? |
Sorry just haven't found a time to review yet, I'll give it a pass soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been using mise for tool management and had started trying to use
tasks
but ran into some issues when trying to run from nested dirs.Have a minimal test setup with 3 cases and was able to figure out some changes for 2 of the cases.
dir setup and all
mise tasks run
commands should be executed from within therunner
dir.mise.toml contents
Leaving this as a draft pr as not very familiar with rust or the codebase so there are likely better ways of fixing these.
Hope this helps make it easier for folks to investigate further.
case1 successfully executes without any changes however it seems to use the current directory instead of the project root as mentioned in the documentation.
root cause for case2 seems to be that
dir
is not rendered usingtera
when loading tasks from the toml config (it works for script tasks) so the path substitutions do not happen within the dir path.Believe for case3 it is something similar where the project root is not being added as a prefix to the file path for the script, however wasn't able to find or confirm if that is the case. Had tried a variation of case3 with specifying the
dir = "{{config_root}}"
to check if thecase2
fix would have helped with no luck.