fix: correct mise shell setting env in nushell
#2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `mise shell` doesn't have an effect in latest nushell. Functions in nushell that want to export environment variables must use the `--env` flag in the function definition. This flag was used on other functions in mise.nu as required (eg. update-env), however it seems that this flag is also required on the `main` function that manages updating the env for `mise shell`.
samuelallan72
force-pushed
the
env-nushell
branch
from
b61714f
to
04084f5
Compare
samuelallan72
changed the title
mise shell setting env in nushellmise shell setting env in nushell
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in nushell that want to export environment variables must use the
--envflag in the function definition. This flag was used on other functions in mise.nu as required (eg. update-env), however it seems that this flag is also required on themainfunction that manages updating the env formise shell.