Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow installing cargo packages with --git #2430

Merged
merged 1 commit into from
Aug 3, 2024
Merged

feat: allow installing cargo packages with --git #2430

merged 1 commit into from
Aug 3, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Aug 3, 2024

Fixes #2420

Copy link

codacy-production bot commented Aug 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% 69.84%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f6e8d43) 17222 13759 79.89%
Head commit (6c8d1cf) 17269 (+47) 13788 (+29) 79.84% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2430) 63 44 69.84%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx force-pushed the cargo-git branch 2 times, most recently from 35646c0 to 3f61077 Compare August 3, 2024 19:08
@@ -57,7 +57,9 @@ impl FromStr for ToolVersionType {

fn from_str(s: &str) -> Result<Self, Self::Err> {
Ok(match s.split_once(':') {
Some(("ref", r)) => Self::Ref(r.to_string()),
Some((ref_type @ ("ref" | "tag" | "branch" | "rev"), r)) => {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my first time ever using this syntax—I never saw the use-case until today!

Copy link

github-actions bot commented Aug 3, 2024

Code Coverage

Package Line Rate Complexity Health
src.backend 68% 0
src 86% 0
src.cli 82% 0
src.cli.alias 89% 0
src.cli.args 97% 0
src.cli.backends 95% 0
src.cli.cache 95% 0
src.cli.config 92% 0
src.cli.direnv 80% 0
src.cli.generate 87% 0
src.cli.plugins 86% 0
src.cli.settings 93% 0
src.cli.sync 27% 0
src.cli.tasks 71% 0
src.config.config_file 89% 0
src.config 88% 0
src.plugins 90% 0
src.plugins.core 55% 0
src.shell 98% 0
src.toolset 86% 0
src.ui 63% 0
Summary 80% (13788 / 17269) 0

@jdx jdx merged commit 754e895 into main Aug 3, 2024
11 of 12 checks passed
@jdx jdx deleted the cargo-git branch August 3, 2024 19:35
triarius pushed a commit to triarius/mise that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install from cargo backend using --git
1 participant