-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow installing cargo packages with --git
#2430
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
35646c0
to
3f61077
Compare
@@ -57,7 +57,9 @@ impl FromStr for ToolVersionType { | |||
|
|||
fn from_str(s: &str) -> Result<Self, Self::Err> { | |||
Ok(match s.split_once(':') { | |||
Some(("ref", r)) => Self::Ref(r.to_string()), | |||
Some((ref_type @ ("ref" | "tag" | "branch" | "rev"), r)) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is my first time ever using this syntax—I never saw the use-case until today!
|
Fixes #2420