fix(src/path_env.rs): Issue 2504: Fix for JoinPathsError #2511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original submitter of Issue 2504 triggered the JoinPathsError when adding a python env in the [env] section:
I noticed the same error independently when using the
poetry
plugin and attempting to run[tasks]
. Consider the following.mise.toml
file that works fine:Running the
foo
task works:But now if I activate that
virtualenv
config line:Now running the task triggers the same JoinPathsErr:
In exploring the bug I observed that path_env.add() was being called with two copies of the
.venv
directory concatenated with a colon ":". So my fix is to update the add() function to check for this, split the path argument on ":" and add each element.My proposed fix is in
./src/path_env.rs