Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added postinstall hook #2654

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: added postinstall hook #2654

merged 1 commit into from
Sep 25, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Sep 25, 2024

Fixes #1014

Copy link

Code Coverage

Package Line Rate Complexity Health
src.backend 65% 0
src 87% 0
src.cli 80% 0
src.cli.alias 89% 0
src.cli.args 97% 0
src.cli.backends 95% 0
src.cli.cache 88% 0
src.cli.config 93% 0
src.cli.direnv 80% 0
src.cli.generate 87% 0
src.cli.plugins 84% 0
src.cli.settings 94% 0
src.cli.sync 56% 0
src.cli.tasks 74% 0
src.config.config_file 85% 0
src.config 86% 0
src.plugins 80% 0
src.plugins.core 55% 0
src.shell 98% 0
src.toolset 88% 0
src.ui 64% 0
Summary 79% (14945 / 18800) 0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.16% 23.08%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6cb1c60) 18790 14968 79.66%
Head commit (6f3242e) 18800 (+10) 14945 (-23) 79.49% (-0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2654) 13 3 23.08%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx merged commit 90c72dc into main Sep 25, 2024
15 checks passed
@jdx jdx deleted the postinstall branch September 25, 2024 18:18
@jasisk
Copy link
Contributor

jasisk commented Sep 25, 2024

@jdx I'd added the tiny bit of config ages ago for corepack specifically in the node plugin (MISE_NODE_COREPACK)—would you like me to remove that bit of functionality now that this much more generally-useful hook is in place?

@jdx
Copy link
Owner Author

jdx commented Sep 25, 2024

nah I think that can stay for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide way to specify simple post-install hooks/commands to run for tools (e.g NodeJS corepack)
2 participants