-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: describe mise behavior when mise version is lower than min_version #2994
Conversation
Thanks. Also it's not clear to me what section this key goes in — the other |
Oh, I see, it's actually not in a section — that might be worth stating explicitly! |
Actually experimenting with this for once, it looks like the impact of this (similar to, say, a TOML parse error) is that mise does not update PATH (etc) but also doesn't actively clear PATH entries from previous mise runs. |
I would keep this out of this PR because other sections follow similar style.
Good find. This looks like a problem but a trivial one. It's easy to reload the interactive shell for mise users. If there are more complains, we could look into it. What do you think? |
f676f7a
to
fc1a37a
Compare
docs/configuration.md
Outdated
@@ -2,23 +2,23 @@ | |||
|
|||
## `mise.toml` | |||
|
|||
`mise.toml` is the config file for mise. They can be at any of the following file paths (in order of precedence, top overrides configuration of lower paths): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change these back
docs/configuration.md
Outdated
the currently installed version, mise will: | ||
|
||
- Ignore the configuration file. | ||
- Output a warning message. | ||
- Terminate execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the currently installed version, mise will: | |
- Ignore the configuration file. | |
- Output a warning message. | |
- Terminate execution. | |
the currently installed version, mise will error out. |
fc1a37a
to
e2eaf6d
Compare
e2eaf6d
to
71f7781
Compare
Thanks for fixing my previous PR. This PR addresses @glasser's comment.