Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe mise behavior when mise version is lower than min_version #2994

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

erickguan
Copy link
Contributor

@erickguan erickguan commented Nov 11, 2024

Thanks for fixing my previous PR. This PR addresses @glasser's comment.

@glasser
Copy link
Contributor

glasser commented Nov 11, 2024

Thanks. Also it's not clear to me what section this key goes in — the other ### headings are section names?

@glasser
Copy link
Contributor

glasser commented Nov 11, 2024

Oh, I see, it's actually not in a section — that might be worth stating explicitly!

@glasser
Copy link
Contributor

glasser commented Nov 11, 2024

Actually experimenting with this for once, it looks like the impact of this (similar to, say, a TOML parse error) is that mise does not update PATH (etc) but also doesn't actively clear PATH entries from previous mise runs.

@erickguan
Copy link
Contributor Author

it's actually not in a section — that might be worth stating explicitly!

I would keep this out of this PR because other sections follow similar style.

Actually experimenting with this for once, it looks like the impact of this (similar to, say, a TOML parse error) is that mise does not update PATH (etc) but also doesn't actively clear PATH entries from previous mise runs.

Good find. This looks like a problem but a trivial one. It's easy to reload the interactive shell for mise users. If there are more complains, we could look into it. What do you think?

@@ -2,23 +2,23 @@

## `mise.toml`

`mise.toml` is the config file for mise. They can be at any of the following file paths (in order of precedence, top overrides configuration of lower paths):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change these back

Comment on lines 135 to 139
the currently installed version, mise will:

- Ignore the configuration file.
- Output a warning message.
- Terminate execution.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the currently installed version, mise will:
- Ignore the configuration file.
- Output a warning message.
- Terminate execution.
the currently installed version, mise will error out.

@jdx jdx merged commit 8b77d2e into jdx:main Nov 28, 2024
21 checks passed
@erickguan erickguan deleted the config-mise branch November 28, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants