Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tv.pathname() in mise ls #3217

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: use tv.pathname() in mise ls #3217

merged 2 commits into from
Nov 27, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 26, 2024

Fixes #2870

this converts ":" and "/" to "-" which is the directory name

@jdx jdx enabled auto-merge (squash) November 26, 2024 20:14
Copy link

github-actions bot commented Nov 26, 2024

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main x -- echo 19.4 ± 0.6 18.1 22.6 1.02 ± 0.04
mise-2024.11.30 x -- echo 19.3 ± 0.6 18.0 22.9 1.01 ± 0.04
mise x -- echo 19.1 ± 0.5 17.8 21.5 1.00

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main env 15.5 ± 0.5 14.3 16.7 1.01 ± 0.04
mise-2024.11.30 env 15.3 ± 0.5 14.2 17.0 1.00
mise env 16.0 ± 0.5 14.7 17.3 1.04 ± 0.05

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main hook-env 16.0 ± 0.6 14.6 17.6 1.01 ± 0.06
mise-2024.11.30 hook-env 16.0 ± 0.5 14.5 17.5 1.01 ± 0.06
mise hook-env 15.8 ± 0.7 14.4 25.2 1.00

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main ls 13.5 ± 0.4 12.6 16.2 1.05 ± 0.04
mise-2024.11.30 ls 12.9 ± 0.3 12.2 13.8 1.00
mise ls 13.0 ± 0.3 12.5 14.1 1.01 ± 0.03

@jdx jdx force-pushed the prune-short branch 2 times, most recently from e95418f to 4bc4f0d Compare November 26, 2024 20:33
@jdx jdx changed the title fix: use tv.short in mise prune fix: kebab-case tv.to_string() Nov 26, 2024
@jdx jdx disabled auto-merge November 26, 2024 21:51
@jdx jdx changed the title fix: kebab-case tv.to_string() fix: use tv.pathname() in mise ls Nov 26, 2024
@jdx jdx force-pushed the prune-short branch 4 times, most recently from 68e9a45 to 59866c0 Compare November 26, 2024 23:19
Copy link

codacy-production bot commented Nov 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6882f531 97.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6882f53) Report Missing Report Missing Report Missing
Head commit (6c7c317) 43113 25159 58.36%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3217) 39 38 97.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jdx jdx force-pushed the prune-short branch 2 times, most recently from ae9e593 to 6b4bfc2 Compare November 27, 2024 00:13
@jdx jdx enabled auto-merge (squash) November 27, 2024 00:13
@jdx jdx merged commit a06299e into main Nov 27, 2024
19 checks passed
@jdx jdx deleted the prune-short branch November 27, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mise prune wanna remove a tool just installed by mise use: probably version tag slash/dash issue
1 participant