feat: add the users PATH to `mise doctor` #3474

syhol · 2024-12-11T17:03:13Z

(don't judge me for my double ~/.local/bin I have reasons)

New mise doctor output

❯ mise doctor
version: 2024.12.6-DEBUG macos-arm64 (edc962e 2024-12-11)
activated: yes
shims_on_path: no

build_info:
  Target: aarch64-apple-darwin
  Features: CLAP_MANGEN, DEFAULT, NATIVE_TLS, OPENSSL, RUSTLS, RUSTLS_NATIVE_ROOTS
  Built: Wed, 11 Dec 2024 16:29:39 +0000
  Rust Version: rustc 1.83.0 (90b35a623 2024-11-26)
  Profile: debug

shell:
  /opt/homebrew/bin/fish
  fish, version 3.7.1

dirs:
  cache: ~/Library/Caches/mise
  config: ~/.config/mise
  data: ~/.local/share/mise
  shims: ~/.local/share/mise/shims
  state: ~/.local/state/mise

config_files:
  ~/.config/mise/config.toml

backends:
  aqua
  asdf
  cargo
  core
  gem
  go
  npm
  pipx
  spm
  ubi
  vfox

plugins:
  asdf-antiarchitect-asdf-helm              https://github.com/Antiarchitect/asdf-helm.git#085651c
  asdf-https-github-com-virtualstaticvoid-asdf-sonarscanner-git  https://github.com/virtualstaticvoid/asdf-sonarscanner.git#c42dd95
  asdf-https-gitlab-com-wt0f-asdf-kubectx   https://gitlab.com/wt0f/asdf-kubectx#8c0b4aa
  asdfnode                                  https://github.com/asdf-vm/asdf-nodejs.git#93bd217
  awscli                                    https://github.com/MetricMike/asdf-awscli.git#c26bbb4
  flutter                                   https://github.com/oae/asdf-flutter.git#d736066
  helm-diff                                 https://github.com/dex4er/asdf-helm-diff.git#47bb84b
  pdm                                       https://github.com/1oglop1/asdf-pdm.git#0223762
  sonar-scanner                             https://github.com/virtualstaticvoid/asdf-sonarscanner.git#c42dd95
  yarn                                      https://github.com/mise-plugins/asdf-yarn.git#74ea3b9

toolset:
  aqua:astral-sh/uv@0.5.5
  core:bun@1.1.38
  core:deno@2.1.2
  core:go@1.23.3
  core:node@23.3.0
  core:rust@1.83.0
  spm:danger/swift@3.20.2
  ubi:aquaproj/aqua@2.38.1
  ubi:jdx/usage@1.4.0
  ubi:pkgxdev/pkgx@1.3.1

path:
  ~/.local/share/mise/installs/node/23.3.0/bin
  ~/.local/share/mise/installs/deno/2.1.2/bin
  ~/.local/share/mise/installs/deno/2.1.2/.deno/bin
  ~/.local/share/mise/installs/bun/1.1.38/bin
  ~/.local/share/mise/installs/uv/0.5.5/uv-aarch64-apple-darwin
  ~/.local/share/mise/installs/go/1.23.3/bin
  ~/.local/share/mise/installs/usage/1.4.0/bin
  ~/.local/share/mise/installs/ubi-aquaproj-aqua/2.38.1/bin
  ~/.local/share/mise/installs/ubi-pkgxdev-pkgx/1.3.1/bin
  ~/.local/share/mise/installs/danger-swift/3.20.2/bin
  ~/.local/share/cargo/bin
  /opt/homebrew/bin
  /opt/homebrew/sbin
  ~/.local/bin
  ~/.local/bin
  /usr/local/bin
  /System/Cryptexes/App/usr/bin
  /usr/bin
  /bin
  /usr/sbin
  /sbin
  /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin
  /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin
  /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin

env_vars:
  MISE_RUSTUP_HOME=~/.local/share/rustup
  MISE_CARGO_HOME=~/.local/share/cargo

settings:
  experimental  true ~/.config/mise/config.toml
  npm.bun       true ~/.config/mise/config.toml
  pipx.uvx      true ~/.config/mise/config.toml

No problems found

Playing with PATH

Fish no path (note single . at the end)

❯ PATH= mise doctor
...
path:
  ~/.local/share/mise/installs/node/23.3.0/bin
  ~/.local/share/mise/installs/deno/2.1.2/bin
  ~/.local/share/mise/installs/deno/2.1.2/.deno/bin
  ~/.local/share/mise/installs/bun/1.1.38/bin
  ~/.local/share/mise/installs/uv/0.5.5/uv-aarch64-apple-darwin
  ~/.local/share/mise/installs/go/1.23.3/bin
  ~/.local/share/mise/installs/usage/1.4.0/bin
  ~/.local/share/mise/installs/ubi-aquaproj-aqua/2.38.1/bin
  ~/.local/share/mise/installs/ubi-pkgxdev-pkgx/1.3.1/bin
  ~/.local/share/mise/installs/danger-swift/3.20.2/bin
  ~/.local/share/cargo/bin
  .

1 problem found:
...

zsh no path

❯ PATH= mise doctor
...
path:
  ~/.local/share/mise/installs/node/23.3.0/bin
  ~/.local/share/mise/installs/deno/2.1.2/bin
  ~/.local/share/mise/installs/deno/2.1.2/.deno/bin
  ~/.local/share/mise/installs/bun/1.1.38/bin
  ~/.local/share/mise/installs/uv/0.5.5/uv-aarch64-apple-darwin
  ~/.local/share/mise/installs/go/1.23.3/bin
  ~/.local/share/mise/installs/usage/1.4.0/bin
  ~/.local/share/mise/installs/ubi-aquaproj-aqua/2.38.1/bin
  ~/.local/share/mise/installs/ubi-pkgxdev-pkgx/1.3.1/bin
  ~/.local/share/mise/installs/danger-swift/3.20.2/bin
  ~/.local/share/cargo/bin

1 problem found:
...

bash no path

❯ PATH= mise doctor
...
path:
  ~/.local/share/mise/installs/node/23.3.0/bin
  ~/.local/share/mise/installs/deno/2.1.2/bin
  ~/.local/share/mise/installs/deno/2.1.2/.deno/bin
  ~/.local/share/mise/installs/bun/1.1.38/bin
  ~/.local/share/mise/installs/uv/0.5.5/uv-aarch64-apple-darwin
  ~/.local/share/mise/installs/go/1.23.3/bin
  ~/.local/share/mise/installs/usage/1.4.0/bin
  ~/.local/share/mise/installs/ubi-aquaproj-aqua/2.38.1/bin
  ~/.local/share/mise/installs/ubi-pkgxdev-pkgx/1.3.1/bin
  ~/.local/share/mise/installs/danger-swift/3.20.2/bin
  ~/.local/share/cargo/bin

1 problem found:
...

fish 2 fake paths

❯ PATH=foo:bar mise doctor
...
path:
  ~/.local/share/mise/installs/node/23.3.0/bin
  ~/.local/share/mise/installs/deno/2.1.2/bin
  ~/.local/share/mise/installs/deno/2.1.2/.deno/bin
  ~/.local/share/mise/installs/bun/1.1.38/bin
  ~/.local/share/mise/installs/uv/0.5.5/uv-aarch64-apple-darwin
  ~/.local/share/mise/installs/go/1.23.3/bin
  ~/.local/share/mise/installs/usage/1.4.0/bin
  ~/.local/share/mise/installs/ubi-aquaproj-aqua/2.38.1/bin
  ~/.local/share/mise/installs/ubi-pkgxdev-pkgx/1.3.1/bin
  ~/.local/share/mise/installs/danger-swift/3.20.2/bin
  ~/.local/share/cargo/bin
  foo
  bar

2 problems found:
...

jdx · 2024-12-11T17:14:49Z

src/cli/doctor.rs

@@ -246,6 +247,13 @@ fn mise_env_vars() -> String {
    vars.iter().map(|(k, v)| format!("{k}={v}")).join("\n")
 }

+fn paths() -> String {
+    if env::PATH_NON_PRISTINE.is_empty() {


this would only work if mise is activated. I think you need to use this:

mise/src/toolset/mod.rs

Line 505 in c6b7e51

pub fn full_env(&self) -> Result<BTreeMap<String, String>> {

I think you'll need to do it here so you have access to the toolset object

mise/src/cli/doctor.rs

Line 141 in 6823a9f

self.analyze_toolset(&ts)?;

Updated to use toolset.full_env. This has move the path section above env_vars as a consequence.

syhol and others added 2 commits December 11, 2024 16:46

feat: add the users PATH to mise doctor

831943e

[autofix.ci] apply automated fixes

e4610bf

jdx requested changes Dec 11, 2024

View reviewed changes

use toolset.full_env instead

566f566

jdx enabled auto-merge (squash) December 11, 2024 18:08

jdx merged commit 5d57bd2 into jdx:main Dec 11, 2024
19 checks passed

This was referenced Dec 11, 2024

chore: release 2024.12.7 #3476

Merged

chore: release 2024.12.8 #3498

Merged

mise 2024.12.7 Homebrew/homebrew-core#200917

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add the users PATH to `mise doctor` #3474

feat: add the users PATH to `mise doctor` #3474

syhol commented Dec 11, 2024 •

edited

Loading

jdx Dec 11, 2024

jdx Dec 11, 2024 •

edited

Loading

syhol Dec 11, 2024

feat: add the users PATH to mise doctor #3474

feat: add the users PATH to mise doctor #3474

Conversation

syhol commented Dec 11, 2024 • edited Loading

New mise doctor output

Playing with PATH

jdx Dec 11, 2024

Choose a reason for hiding this comment

jdx Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

syhol Dec 11, 2024

Choose a reason for hiding this comment

feat: add the users PATH to `mise doctor` #3474

feat: add the users PATH to `mise doctor` #3474

syhol commented Dec 11, 2024 •

edited

Loading

jdx Dec 11, 2024 •

edited

Loading