fix: disable reverse uv syncing #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdx
added a commit
that referenced
this pull request
Dec 19, 2024
miguelmig
pushed a commit
to miguelmig/mise
that referenced
this pull request
Dec 21, 2024
* fix: disable reverse uv syncing Fixes jdx#3654 * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
miguelmig
pushed a commit
to miguelmig/mise
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3654
it does not appear this is going to be possible right now at least without a bunch of work modifying sysconfig. If someone really wants this they'll need to figure out how to get mise to patch sysconfig the same way uv does: https://github.com/astral-sh/uv/blob/main/crates/uv-python/src/sysconfig/mod.rs#L217
it is rust though, so maybe we could just copy their code? Funnily enough it seems that's what they did reading the license information in the header.
It's probably also worth pinging the uv team and asking if they have any plans around the indygreg binaries that would make this easier for mise.