-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow dotnet prerelease #3753
Conversation
@@ -28,9 +28,10 @@ impl Backend for DotnetBackend { | |||
let feed_url = self.get_search_url()?; | |||
|
|||
let feed: NugetFeedSearch = HTTP_FETCH.json(format!( | |||
"{}?q={}&packageType=dotnettool&take=1", | |||
"{}?q={}&packageType=dotnettool&take=1&prerelease={}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there other flags we might be able to send? I'm thinking of a setting that might allow more functionality like MISE_DOTNET_PACKAGE_FLAGS=prerelease
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no other parameters to send to the nuget api, I let you decide what you prefer and I can implement it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check something and if it's better to implement your solution for the future , do not merge it yet please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, should this actually be a tool option? Or maybe we support both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good idea, I think I'll implement it, it's better if it works the same everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After investigation the prerelease
is at the _list_remote_versions
level not at the install_version_
so doesn't have access to tv.request.options()
Allow prerelease