Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dotnet prerelease #3753

Merged
merged 5 commits into from
Dec 21, 2024
Merged

Conversation

acesyde
Copy link
Contributor

@acesyde acesyde commented Dec 21, 2024

Allow prerelease

@@ -28,9 +28,10 @@ impl Backend for DotnetBackend {
let feed_url = self.get_search_url()?;

let feed: NugetFeedSearch = HTTP_FETCH.json(format!(
"{}?q={}&packageType=dotnettool&take=1",
"{}?q={}&packageType=dotnettool&take=1&prerelease={}",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there other flags we might be able to send? I'm thinking of a setting that might allow more functionality like MISE_DOTNET_PACKAGE_FLAGS=prerelease or something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no other parameters to send to the nuget api, I let you decide what you prefer and I can implement it 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check something and if it's better to implement your solution for the future , do not merge it yet please

Copy link
Owner

@jdx jdx Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, should this actually be a tool option? Or maybe we support both?

https://mise.jdx.dev/dev-tools/#tool-options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm good idea, I think I'll implement it, it's better if it works the same everywhere

Copy link
Contributor Author

@acesyde acesyde Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After investigation the prerelease is at the _list_remote_versions level not at the install_version_ so doesn't have access to tv.request.options()

@jdx jdx marked this pull request as draft December 21, 2024 13:14
@acesyde acesyde requested a review from jdx December 21, 2024 17:49
@jdx jdx marked this pull request as ready for review December 21, 2024 17:50
@jdx jdx merged commit 6393920 into jdx:main Dec 21, 2024
18 checks passed
@acesyde acesyde deleted the feature/allow_dotnet_prerelease branch December 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants