Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shells: add special nix behavior #675

Merged
merged 1 commit into from
Jul 13, 2023
Merged

shells: add special nix behavior #675

merged 1 commit into from
Jul 13, 2023

Conversation

pedorich-n
Copy link
Contributor

Following the discussion: #671 (comment), adding a special behavior for when rtx is installed under the /nix prefix: do not add rtx binary to the PATH environment variable.

@jdx jdx enabled auto-merge (squash) July 13, 2023 14:31
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -7.43 ⚠️

Comparison is base (6cc9e92) 88.08% compared to head (0126564) 80.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   88.08%   80.66%   -7.43%     
==========================================
  Files         129      129              
  Lines       11124    11159      +35     
==========================================
- Hits         9799     9001     -798     
- Misses       1325     2158     +833     
Impacted Files Coverage Δ
src/shell/bash.rs 100.00% <100.00%> (ø)
src/shell/fish.rs 100.00% <100.00%> (ø)
src/shell/mod.rs 72.09% <100.00%> (-6.86%) ⬇️
src/shell/nushell.rs 100.00% <100.00%> (ø)
src/shell/xonsh.rs 100.00% <100.00%> (ø)
src/shell/zsh.rs 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdx jdx merged commit e1b3ecf into jdx:main Jul 13, 2023
@pedorich-n pedorich-n deleted the shells-nix-behavior branch July 13, 2023 23:54
jdx pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants