Avoid panic if run_with_timeout hits timeout. #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If run_with_timeout hits the timeout, the mpsc receiver may be dropped, leading to a panic when the background thread later attempts to return its value. This change simply ignores any error. Since the timeout has already been reached, reporting on this error would just be noise. A future improvement could be to cancel the background operation, but that would require a much larger refactoring. Part of #860
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 87.45% 83.80% -3.66%
==========================================
Files 132 132
Lines 11578 11579 +1
==========================================
- Hits 10126 9704 -422
- Misses 1452 1875 +423
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If run_with_timeout hits the timeout, the mpsc receiver may be dropped, leading to a panic when the background thread later attempts to return its value.
This change simply ignores any error. Since the timeout has already been reached, reporting on this error would just be noise.
A future improvement could be to cancel the background operation, but that would require a much larger refactoring.
Part of #860