Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctor: allow shims on PATH to hide inactive problem #916

Merged
merged 1 commit into from
Sep 25, 2023
Merged

doctor: allow shims on PATH to hide inactive problem #916

merged 1 commit into from
Sep 25, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Sep 25, 2023

since that's a valid way to use rtx

@jdx jdx changed the title doctor test out mold linker doctor: allow shims on PATH to hide inactive problem Sep 25, 2023
@jdx jdx changed the title test out mold linker doctor: allow shims on PATH to hide inactive problem doctor: allow shims on PATH to hide inactive problem Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.86% ⚠️

Comparison is base (962e615) 87.45% compared to head (514adbe) 80.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   87.45%   80.59%   -6.86%     
==========================================
  Files         132      132              
  Lines       11590    11596       +6     
==========================================
- Hits        10136     9346     -790     
- Misses       1454     2250     +796     
Files Changed Coverage Δ
src/cli/doctor.rs 0.69% <0.00%> (-81.92%) ⬇️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit c3de328 into main Sep 25, 2023
15 of 17 checks passed
@jdx jdx deleted the doctor branch September 25, 2023 15:51
jdx pushed a commit that referenced this pull request Apr 9, 2024
Co-authored-by: James Hegedus <jthegedus@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant