Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include the generator for mount run commands #154

Merged
merged 4 commits into from
Nov 4, 2024
Merged

fix: Include the generator for mount run commands #154

merged 4 commits into from
Nov 4, 2024

Conversation

miguelmig
Copy link
Contributor

@miguelmig
Copy link
Contributor Author

Still not working perfectly need to dig a bit deeper, don't merge yet

@miguelmig miguelmig marked this pull request as draft November 4, 2024 20:06
@jdx
Copy link
Owner

jdx commented Nov 4, 2024 •
edited
Loading

I'm trying to fix your PR because the job is failing by merging from main, you can feel free to overwrite. I can only test this using a fork.

@miguelmig miguelmig marked this pull request as ready for review November 4, 2024 20:37
@miguelmig
Copy link
Contributor Author

miguelmig commented Nov 4, 2024 •
edited
Loading

It seems to work now locally.
If, out of nowhere, it breaks tomorrow I'll investigate if it's something related to caching or the likes.
image

@jdx jdx merged commit cae6007 into jdx:main Nov 4, 2024
2 checks passed
@mise-en-dev mise-en-dev mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelmig @jdx