Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler and reduce final image size #1

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

usimd
Copy link
Contributor

@usimd usimd commented Jun 3, 2021

GitHub actions failed with errors indicating no space was left on the drive. This PR runs will clean apt resources after installation and only install IDE components for 8bit MCUs.

Locally, this resulted in an image size of ~5.5GB compared to ~10GB before the change.

@jeandeaual
Copy link
Owner

Thanks, that looks great!
Just one thing: can you keep the XC8 version to 1.34 in this PR? I have a project that needs this specific version.
I'll try to make it customizable in another PR.

README.md Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Alexis Jeandeau <alexis.jeandeau@gmail.com>
@usimd
Copy link
Contributor Author

usimd commented Jun 7, 2021

Setting the versions externally as params would be awesome 😄

jeandeaual added a commit to jeandeaual/new-keyboard that referenced this pull request Jun 8, 2021
@jeandeaual jeandeaual merged commit 3f7fde1 into jeandeaual:master Jun 8, 2021
@jeandeaual
Copy link
Owner

@usimd Thanks again for the PR!
I just released your changes as jeandeaual/mplabx-xc8-build-action@v0.2.0 and you can follow #2 regarding setting the XC8 version as a parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants