fix: include insensitive case to get content-type in header filters #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauricioBarbosa
approved these changes
Aug 16, 2023
henriquemarioto
approved these changes
Aug 16, 2023
| @@ -31,12 +31,12 @@ public function __construct($allowedExtensions) | |||
|
|
|||
|
|
|||
| public function applyHeaderFilter(array $headers) { | |||
| if(!array_key_exists('Content-Type', $headers) && count($headers['Content-Type']) > 0){ | |||
| $contentType = $headers['Content-Type'][0] ?? $headers['content-type'][0] ?? null; | |||
There was a problem hiding this comment.
n tem problema acessar a primeira posição antes de validar se existe o Content-Type? a validação que tinha antes verificava isso
There was a problem hiding this comment.
vou adicionar uma condição antes para verificar se existe o content-type mas a srgunda parte da condição anterior não fez sentido pra mim, ja que se não existir o content type não podemos verificar a quantidade de valores nesse campo
jeansouzak
reviewed
Aug 16, 2023
jeansouzak
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including validation to get content-type in different word cases