Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows launch scripts #13

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

GenZmeY
Copy link
Contributor

@GenZmeY GenZmeY commented Oct 31, 2024

Hey

I tried to use dependency-finder tools (v1.4.0) on Windows and I get errors like this:

Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/oro/text/perl/Perl5Util
    at com.jeantessier.dependency.NodeFactory.<clinit>(NodeFactory.java:41)
    at com.jeantessier.dependencyfinder.cli.DependencyExtractor.doProcessing(DependencyExtractor.java:68)
    at com.jeantessier.dependencyfinder.cli.Command.process(Command.java:178)
    at com.jeantessier.dependencyfinder.cli.Command.run(Command.java:102)
    at com.jeantessier.dependencyfinder.cli.DependencyExtractor.main(DependencyExtractor.java:101)
Caused by: java.lang.ClassNotFoundException: org.apache.oro.text.perl.Perl5Util
    at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
    at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
    ... 5 more

At the same time, everything works fine on Linux

I changed the bat files a bit so that they added all *.jar files from %DEPENDENCYFINDER_HOME%\lib\ to the classpath (similar to how it is done in unix scripts) and it helped me, I was able to use the tools with Windows now

so I propose this PR with changes for bat files, maybe it will be useful

All *.jar files found in %DEPENDENCYFINDER_HOME%\lib\
will be added to the classpath parameter.
@GenZmeY GenZmeY changed the title Fix filling classpath with jars for bat files Fix windows launch scripts Nov 1, 2024
Copy link
Owner

@jeantessier jeantessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thx!! (I don't have a Windows machine anymore, so I couldn't test these scripts.)

@jeantessier jeantessier merged commit 6c5401d into jeantessier:main Nov 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants