-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printw
should not be exposed.
#172
Comments
This function still should have been marked as unsafe, since it's trivial to cause an exploitable memory safety issue when calling it... |
Deprecation is definitely insufficient because it's not transitive, and more importantly, people do not expect "deprecated" to mean "using this may cause memory errors". However, that's exactly what This is a serious security issue - such bugs can be easily exploited to get remote code execution. Please mark |
Because the usage of 'printw' is deprecated. Also see: jeaye/ncurses-rs#172
It's very difficult / impossible to use this function from rust without introducing a format string vulnerability into your code (which can be used to trigger arbitrary code execution).
If you must expose something like it, have it just call addstr or mark it as unsafe (and deprecate it in both cases, IMO).
See also: #149 and #125.
The text was updated successfully, but these errors were encountered: