Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock HTTP-Requests and django file storage in tests #17

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Mock HTTP-Requests and django file storage in tests #17

merged 1 commit into from
Nov 24, 2020

Conversation

jedie
Copy link
Owner

@jedie jedie commented Nov 24, 2020

Additional changes:

  • Use requests in for_runners/weather.py
  • Cache OSM reverse requests

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #17 (1ca9e9f) into master (40fe27d) will increase coverage by 0.78%.
The diff coverage is 99.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   72.75%   73.53%   +0.78%     
==========================================
  Files          74       75       +1     
  Lines        2606     2687      +81     
==========================================
+ Hits         1896     1976      +80     
- Misses        710      711       +1     
Impacted Files Coverage Δ
src/for_runners/weather.py 89.32% <87.50%> (-0.59%) ⬇️
src/for_runners/geo.py 93.33% <100.00%> (+4.04%) ⬆️
src/for_runners/services/gpx_create.py 88.63% <100.00%> (+0.26%) ⬆️
src/for_runners/tests/fixture_files/__init__.py 100.00% <100.00%> (ø)
src/for_runners/tests/test_admin.py 100.00% <100.00%> (ø)
src/for_runners/tests/test_command_import.py 100.00% <100.00%> (ø)
src/for_runners/tests/test_geo.py 100.00% <100.00%> (ø)
src/for_runners/tests/test_services_gpx_create.py 100.00% <100.00%> (ø)
src/for_runners/tests/test_weather.py 100.00% <100.00%> (ø)
src/for_runners/tests/utils.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fe27d...684dcff. Read the comment docs.

Additional changes:

* Use requests in `for_runners/weather.py`
* Cache OSM reverse requests
@jedie jedie merged commit 21a7708 into master Nov 24, 2020
@jedie jedie deleted the tests branch November 24, 2020 18:21
@jedie jedie mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant