-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item selection is case-sensitive #45
Comments
So I wrote a better SQL query generation function to generate fuzzy matched queries, but I can't implement it into spark.js and gacha.js without some weird bugs cropping up. (running queries twice, mishandling unsanitized inputs.) Features of the improved query/builder.
Things to be aware of: ORDER BY is not compatible with the COUNT() function by itself. As such, when passing queries to the array to count rows, the first index in the array ( sql[0] ) needs to be 'SELECT COUNT(*)' This can be improved by additional logic on the query inputs towards the last if/else statement. but wasn't necessary for current implementation. Here's the function:
And a usage example:
|
Ideally i'd like to wrap all query generation into this function, including a flag to run SELECT for specific columns (name, id ...) , and builtlins for common SQL functions like COUNT(). But until we know how it'll be implemented it gets a little more awkward to write. |
When querying items with Siero (e.g. to set rate ups, spark targets, etc), Siero looks for exact matches in the database. As such, these commands are case-sensitive. This is inconvenient for most users, especially those on mobile.
The text was updated successfully, but these errors were encountered: